-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplified template resolution #1363
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we're going to fold all that remains of CompatResolver into here.
ef4
added a commit
that referenced
this pull request
Mar 7, 2023
This unskips some tests that were disabled in #1363 by finishing the new implementation of the component.invokes packageRule.
This was referenced May 2, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another extraction from the work in #1357.
It should be able to complete the "stretch goal" described in #1339 by eliminating all real module resolution in our template transform.
I noticed that emberjs/ember.js#19878 got back ported to Ember 3.28, so I don't think we need to keep our workaround for it anymore, and dropping the workaround made this work easier.
Potentially breaking changes to how we up-compile non-strict templates:
{{thing}}
mean{{this.thing}}
. Ember itself doesn't support any versions that can do this anymore. Embroider will now error on this whenstaticComponents
orstaticHelpers
are enabled. If people hit this problem in third-party code, I've added adisambiguate
package rule that can be used to manually disambiguate the cases.{{thing arg=1}}
, you can no longer mix and matchstaticComponents
andstaticHelpers
settings. They either both need to be enabled or both disabled. You can also always switch to unambiguous syntax like<Thing />
or{{ (thing) }}
. This way we can always tell for sure whether we're handling an invocation or not, without making it dependent on the outcome of global resolution.components.*.safeToIgnore
package rule used to just suppress the error when a component wasn't found. Now it prevents us from even attempting resolution.