clarify which package rules apply inside vs outside a component #1362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were keying all component rules off the actual on-disk file for that component, even when those rules were being consume at *invocation sites* of the component rather than inside the component itself. This meant that we could not apply those rules if we move component resolution out of the AST transform stage. But it's actually OK to key the exterior rules off the component's globally-addressable (or at least engine-scoped) name, since the point of the rules is to control classic global resolution.
This was referenced May 2, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were keying all component rules off the actual on-disk file for that component, even when those rules were being consume at invocation sites of the component rather than inside the component itself. This meant that we could not apply those rules if we move component resolution out of the AST transform stage.
But it's actually OK to key the exterior rules off the component's globally-addressable (or at least engine-scoped) name, since the point of the rules is to control classic global resolution.
This is an extraction from findings in #1357. I want to land some smaller steps from that work separately to keep green tests at each point.