Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix resolver bugs around package rules #1347

Merged

Conversation

void-mAlex
Copy link
Collaborator

@void-mAlex void-mAlex commented Jan 31, 2023

order blockParams to be next to componentBlockMarker instead of locals on the scopeStack

@ef4 piecemeal PR that takes us down to only 3 skipped tests (from 10)
if the change is good my preference would be to get this merged and for me to open a new pr when the I get around to the rest especially as I foresee having to add the second babel plugin (babel-plugin-adjust-imports) which means messing with package.json

@ef4 ef4 merged commit b490776 into embroider-build:main Jan 31, 2023
This was referenced May 2, 2023
@ef4 ef4 added the bug Something isn't working label May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants