Bugfix: inconsistent handling of webpack virtual modules #1346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we're having sporadically bad interactions between webpack-virtual-modules and thread-loader. I had reproduced the problem without thread-loader present so I thought I ruled that out, but apparently not. |
This replaces webpack-virtual-modules with our own loader. Ours can be simpler because we can make it stateless. This also involved a larger change to where we tap into webpack. The previous location was unable to redirect to a new loader. This new solution gives us better control.
ef4
force-pushed
the
bugfix-webpack-vfs
branch
from
d5609bc
to
09d1a2f
Compare
This was referenced May 2, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should match the pattern we use when emitting virtual modules.
It works sometimes as it was, but not reliably. This change seems to make the tests pass every time.