Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ember-cli-babel >= v8 for apps and addons #1334

Merged

Conversation

bertdeblock
Copy link
Contributor

No description provided.

@ef4
Copy link
Contributor

ef4 commented Jan 24, 2023

Since the point of this check is to make sure the app is using babel 7, when we encounter ember-cli-babel 8 I think we need to actually check the app's version of @babel/core itself.

if (app has ember-cli-babel 7) {
  we're definitely using @babel/core 7
} else if (app has ember-cli-babel > 7) {
  we need to check what version of @babel/core is in the app
}

@bertdeblock bertdeblock force-pushed the allow-ember-cli-babel-v8-for-v1-addons branch from 8725415 to 594bdef Compare January 24, 2023 20:18
@bertdeblock bertdeblock changed the title Allow ember-cli-babel v8 for v1 addons Allow ember-cli-babel >= v8 for apps and addons Jan 24, 2023
@bertdeblock bertdeblock force-pushed the allow-ember-cli-babel-v8-for-v1-addons branch from 594bdef to f48c87d Compare January 24, 2023 20:24
@ef4 ef4 merged commit 7060328 into embroider-build:main Jan 25, 2023
@ef4
Copy link
Contributor

ef4 commented Jan 25, 2023

Thanks!

@ef4
Copy link
Contributor

ef4 commented Jan 25, 2023

Released in @embroider/compat 2.2.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants