Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move resolving into dedicated plugins #1331

Merged
merged 16 commits into from
Jan 26, 2023
Merged

Move resolving into dedicated plugins #1331

merged 16 commits into from
Jan 26, 2023

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Jan 19, 2023

Supersedes #1311.

While this refactor is landing a webpack plugin, I have already tested that the same shared module-resolver API is fully working under rollup and vite.

@ef4
Copy link
Contributor Author

ef4 commented Jan 19, 2023

Goals as we land this:

  • move all app tree merging into the module-resolver rules, so no physical rewriting of the app is necessary
  • redirect resolution to and from auto-upgraded addons so we don't need to physically recreate the node_modules tree (this would simplify the existing case where v2 addons depend on emberVirtualPeerDeps)
  • refactor class CompatResolver into separate steps: the first would be a one-to-one transformation of the template that always emits standardized imports, the second would be additional rules in the module-resolver that satisfies those imports based on what's actually available.

@ef4 ef4 marked this pull request as ready for review January 26, 2023 19:16
@ef4 ef4 merged commit d94051e into main Jan 26, 2023
@ef4 ef4 deleted the refactor-resolving2 branch January 26, 2023 20:50
@ef4
Copy link
Contributor Author

ef4 commented Jan 26, 2023

The unchecked "goals" list above is things to do in the next PR.

This was referenced May 2, 2023
@ef4 ef4 added the enhancement New feature or request label May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant