Fix Nested V2 Addons #1327
Fix Nested V2 Addons #1327
Conversation
| if (autoImportInstance) { | ||
| autoImportInstance.registerV2Addon(name, root); | ||
| } else { | ||
| (this.parent as EAI2Instance).registerV2Addon(name, root); |
There was a problem hiding this comment.
How do we know it's safe to call this on the parent?
There was a problem hiding this comment.
That's the biggest question mark I have, quote from the issue above:
Why I'm saying this is only a suggested fix: I'm not sure, if this piece of code is in the intention of the comment or if that means a different implementation (given I have basically no real knowledge about embroider).
which basically targets this line.
But following the analysis I put in the issue, there is either a autoImportInstance or this.parent with registerV2Addon available.
There was a problem hiding this comment.
Potentially, you can safeguard this. But I'd say, it would be better to throw an error over silently do nothing and not registering the addon at all, without a dev knowing about it ?!?
There was a problem hiding this comment.
It's safe once refactored inside the if (this.parent.pkg['ember-addon']?.version ?? 1) < 2) check.
|
@ef4 is this ready to move forward? It is improving and at the same time doesn't make it worse? |
|
The test coverage for this is in ember-auto-import, not embroider, because all of this registering v2 addons with ember-auto-import stuff is inert under embroider, it only matters for non-embroider apps where ember-auto-import is doing the work. Opened embroider-build/ember-auto-import#571 to cover this. |
|
Thanks @gossi |
|
Has this made it into a release yet? |
|
yes, https://www.npmjs.com/package/@embroider/addon-shim/v/1.8.4-unstable.00ec2e7
|
|
Also encountering this issue fwiw |
Fix #1325
please refer to linked issue for detailed explanation. I didn't add any tests though, there is no such scenario in the repo. Please let me know how a good test would fit within the existing suite.