Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade resolver tests #1321

Merged
merged 91 commits into from
Jan 25, 2023
Merged

Upgrade resolver tests #1321

merged 91 commits into from
Jan 25, 2023

Conversation

void-mAlex
Copy link
Collaborator

@ef4 here are a couple of them to make sure I'm doing this correctly, the rest will follow

@void-mAlex
refactor "angle contextual component, lower" test
5296ec1
@void-mAlex
refactor "optional component missing in mustache" test
8d8f629
@void-mAlex
refactor "component rules can be expressed via component helper" test
f9e208a
@void-mAlex
refactor "optional component missing in mustache block" test
aab823a
@void-mAlex
remove duplicate test that was refactored in:
fcbc32f 
8d8f629
@void-mAlex
refactor "optional component declared as element missing in mustache …
40d3b79 
…block" test
@void-mAlex
refactor "optional component missing in element" test
e501140
@void-mAlex
refactor "class defined helper not failing if there is no arguments" …
370553e 
…test
@void-mAlex
refactor "class defined helper not failing with arguments" test
3618fb0
@void-mAlex
refactor "helper defined in component not failing if there is no argu…
ff9aa15 
…ments" test
@void-mAlex
refactor "class defined component not failing if there is a block" test
306a2f4
@void-mAlex
refactor "class defined component not failing with arguments" test
95c371e
@void-mAlex
refactor "mustache missing, no args" test
7fee8c6
@void-mAlex
refactor "mustache missing, with args" test
79149f0
@void-mAlex
refactor "string literal passed to "helper" keyword in content positi…
a1bc1b1 
…on" test
@void-mAlex
refactor "string literal passed to "modifier" keyword in content posi…
ab428ac 
…tion" test
@void-mAlex
refactor "modifier currying using the "modifier" keyword" test
5fbff82
@void-mAlex
refactor "built-in components are ignored when used with the componen…
87784db 
…t helper" test
@void-mAlex
refactor "built-in helpers are ignored when used with the "helper" ke…
7c20829 
…yword" test
@void-mAlex
refactor "built-in modifiers are ignored when used with the "modifier…
13f639e 
…" keyword" test
@void-mAlex
refactor "component helper with direct addon package reference" test
269a6ea
@void-mAlex
refactor "component helper with direct addon package reference to a r…
8ef0f50 
…enamed package" test
@void-mAlex
refactor "angle bracket invocation of component with @ syntax" test
3f29c05 
changed `<MyAddon$Thing />` to `<MyAddon@Thing />` to match test description
@ef4
Copy link
Contributor

ef4 commented Jan 10, 2023

Looking good, thanks.

@void-mAlex
*refactor "element block params are not in scope for element's own at…
fcdd95d 
…tributes" test
@void-mAlex
refactor "acceptsComponentArguments on mustache with invalid literal"…
aa3b341 
… test
@void-mAlex
refactor "acceptsComponentArguments interior usage of path generates …
5dbdbb5 
…no warning" test
@void-mAlex
refactor "acceptsComponentArguments interior usage of this.path gener…
e9eee19 
…ates no warning" test
@void-mAlex
refactor "acceptsComponentArguments interior usage of @path generates…
d200e44 
… no warning" test
@void-mAlex
refactor "safeToIgnore a missing component" test
8b4681e
@void-mAlex
*refactor safeToIgnore a present component" test
829c21e
@void-mAlex
*refactor "respects yieldsArguments rule for positional block param, …
53f01cf 
…angle" test
@void-mAlex
refactor "respects yieldsArguments rule for positional block param, c…
6a5197a 
…urly" test
@void-mAlex
refactor "respects yieldsArguments rule for hash block param" test
5b7db62
@void-mAlex
refactor "yieldsArguments causes warning to propagate up lexically, a…
12e4f60 
…ngle" test
@void-mAlex
refactor "yieldsArguments causes warning to propagate up lexically, c…
9ceeef7 
…url" test
@void-mAlex
refactor "yieldsArguments causes warning to propagate up lexically, m…
176fcce 
…ultiple levelsl" test
@void-mAlex
*refactor "respects invokes rule on a component" test
df50d1c
@void-mAlex
*refactor "respects invokes rule on a non-component app template" test
556e84d
@void-mAlex
*refactor "respects invokes rule on a non-component addon template" test
c8f6e24
@void-mAlex
refactor "rejects arbitrary expression in component helper" test
1a62997
@void-mAlex
refactor "ignores any non-string-literal in "helper" keyword" test
c21f6d1
@void-mAlex
refactor "ignores any non-string-literal in "modifier" keyword" test
62eddd2
@void-mAlex
refactor "trusts inline ensure-safe-component helper" test
2e0e1f0
@void-mAlex void-mAlex marked this pull request as ready for review January 12, 2023 23:22
@void-mAlex
Copy link
Collaborator Author

@ef4 have gone through all skipped tests in the resolver.tests.ts file
went through 70+ tests
12 are still skipped as they don't do the expected outcome from the test and cause failures

there are several commits that look like they have the expected outcome (from the test perspective) but I have doubts about intended output of the transform step - I've marked such commits with an * at the beginning so they are easy to spot

looking for input on next steps / criteria to land this

@ef4 ef4 merged commit 208dc09 into embroider-build:main Jan 25, 2023
@github-actions github-actions bot mentioned this pull request Jun 19, 2024
Open
@github-actions github-actions bot mentioned this pull request Jul 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@void-mAlex @ef4