Resolver transform fixes #1308
Closed
Resolver transform fixes #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 16, 2022
The lexical scope changes in 2.0 broke the acceptsComponentArguments rule in the case where there were multiple invocations of the same component and there was no need to choose a different name for the lexically scoped value.
|
This is actually merged but GitHub seems confused. |
ef4
added a commit
that referenced
this pull request
Dec 18, 2022
…ovements Resolver transform fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TwoSeveral bug fixes:acceptsComponentArgumentspackageRule in a case where there are multiple invocations of the same component in the same template where no renaming was required to avoid collisions with the javascript scope.