Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for embroider server running on windows, index.js can be ejected from … #1302

Conversation

void-mAlex
Copy link
Collaborator

…the $TMPDIR cache

resulting in a broken build that can never recover by itself without restarting the dev server

this manifests itself as an error saying @glimmer/tracking/index.js cannot be found

removing the didBuild check results in a few extra invocations of the files output but over the course of a day it's low compared to the disruption caused by the build breakage even if it's not directly caused by the build itself
this change would allow for a better developer experience on windows

…the $TMPDIR cache

resulting in a broken build that can never recover by itself without restarting the dev server
@ef4 ef4 merged commit cbda288 into embroider-build:main Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants