allow v2 addons to use app tree fallback resolution #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are careful to not allow most of the bad backward-compatible kinds of package resolution inside v2 addons. But there's an exception that we need to allow and don't: due to app tree merging, files from a v2 addon can end up needing to resolve back to that v2 addon from the app, even when the v2 addon is not properly resolvable from the app. This is already handled for v1 addons through a process of attempting to resolve from the app, from the original addon, and then from the global list of all known addons. This change allows v2 addons to also use that process, but only when resolving their own name.
ef4
force-pushed
the
nested-v2-resolution-fix
branch
from
d53ba88
to
1f259e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are careful to not allow most of the bad backward-compatible kinds of package resolution inside v2 addons.
But there's an exception that we need to allow and don't: due to app tree merging, files from a v2 addon can end up needing to resolve back to that v2 addon from the app, even when the v2 addon is not properly resolvable from the app.
This is already handled for v1 addons through a process of attempting to resolve from the app, from the original addon, and then from the global list of all known addons. This change allows v2 addons to also use that process, but only when resolving their own name.
Fixes #1175