-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streamline template compilation, part 2 #1276
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes all the template resolver machinery, the next step will be to build it back up on the new API.
Next steps here:
|
I thought we could take first-class helper support for granted since it was supposed to be introduced before 3.28 (our oldest supported ember), but due to: emberjs/ember.js#19878 we can't rely on it until ember 4.2.
So that our tests can keep using the version that doesn't need the helper-bug hack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1242 refactored the stage1 (addon compatibility) template compilation to use the new capabilities of babel-plugin-ember-template-compilation 2.0-alpha.
This PR will do the same for the stage3 (final app build) template compilation.
TODOs and areas to cleanup:
app.ts
babel config changesload-ember-template-compiler.ts
babel-plugin-inline-hbs-deps*
template-compiler-node.ts
template-compiler-common.ts
patch-template-compiler.ts
ember-template-compiler-types.ts
core/src/resolver.ts
compat/src/resolver.ts