Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't generate .js component stubs for .ts components #1273

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Don't generate .js component stubs for .ts components #1273

merged 1 commit into from
Oct 31, 2022

Conversation

bwbuchanan
Copy link

Fixes #1261

@kiosion
Copy link
Contributor

kiosion commented Oct 31, 2022

Can confirm these changes fix #1261 for me, would love to see this merged

@ef4 ef4 merged commit cf998de into embroider-build:main Oct 31, 2022
@ef4 ef4 added the bug Something isn't working label Oct 31, 2022
@ef4
Copy link
Contributor

ef4 commented Oct 31, 2022

Thanks

@xomaczar
Copy link

can we cut a bug fix release?

@dfreeman dfreeman mentioned this pull request Nov 20, 2022
Closed
@ef4 ef4 mentioned this pull request Nov 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@embroider/compat v1.9.0 breaks TypeScript components when staticComponents: true
4 participants
@bwbuchanan @kiosion @ef4 @xomaczar