Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping support for older ember's #1246

Merged
merged 49 commits into from
Oct 27, 2022
Merged

Dropping support for older ember's #1246

merged 49 commits into from
Oct 27, 2022

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Aug 13, 2022

Ember's oldest supported LTS no longer needs the old modules api polyfill and has first-class components. This allows us to drop a whole bunch of complexity.

This PR also includes a refactor of the test suite to get everything onto scenario-tester, so that everything respects the same support matrix. As a practical matter, this means some tests that were co-located within their packages will move into tests/scenarios, because it's somewhat annoying to make it work otherwise. As a benefit, this will improve windows test coverage because all the newer-style tests run on both windows and unix and the older ones did not.

@ef4 ef4 added the breaking label Aug 13, 2022
@ef4
Copy link
Contributor Author

ef4 commented Aug 13, 2022

This breaking release will apply to the core and compat packages. We don't need breaking releases to macros, util, etc.

ef4 added a commit that referenced this pull request Aug 17, 2022
Rebuilds could crash on windows when working with a v1 addon's dummy app.

We already defend against the weird circularity of dummy apps, but the check didn't work on windows.

This has test coverage that will land as part of #1246, because that includes a refactor of the test suite that reveals this problem.
ef4 added a commit that referenced this pull request Aug 17, 2022
When an addon does app.import of a file out of node_modules, the path we use to refer to that file had a mix of different path separators. That doesn't actually break, but the inconsistency made it hard to test and our test suite revealed the problem (in #1246).
@ef4 ef4 marked this pull request as ready for review October 27, 2022 20:31
@ef4
Copy link
Contributor Author

ef4 commented Oct 27, 2022

There is more to do here but this has now completed the refactor of the test suite, which resulted in fixing a bunch of windows bugs, and this branch is huge, so I'm merging to continue in other PRs.

@ef4 ef4 merged commit c276a0d into main Oct 27, 2022
@ef4 ef4 deleted the drop-unuspported-embers branch October 27, 2022 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant