Detect addons with customized treeForMethod names #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The normal way for addons to implement custom treeFor hooks is to... just implement them. But some addons mutate the `treeForMethods` table instead. In fact, some addons mutate *other addons* `treeForMethods` table. *sigh*
ef4
added a commit
that referenced
this pull request
Jul 4, 2022
The bugfix in #1230 caused us to start detecting some very weird old addons as having customized trees, and we can't really do anything with those. It was better to give them the stock tree behaviors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The normal way for addons to implement custom treeFor hooks is to... just implement them.
But some addons mutate the
treeForMethodstable instead. In fact, some addons mutate other addonstreeForMethodstable. 😭