Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip extension from reexport of rollup-app-reexports #1215

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

simonihmig
Copy link
Collaborator

This makes rollup-app-reexports strip file extensions (.js) from reexports, aligning with (the blueprint of) v1 addons, and allowing better interoperability with package.json#exports with path mappings including extensions, as discussed in typed-ember/glint#338.

This makes `rollup-app-reexports` strip file extensions (`.js`) from reexports, aligning with (the blueprint of) v1 addons, and allowing better interoperability with `package.json#exports` with path mappings including extensions, as discussed in typed-ember/glint#338.
source: `export { default } from "${pkg.name}/${addonFilename}";\n`,
source: `export { default } from "${pkg.name}/${addonFilename.slice(
0,
-extname(addonFilename).length
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to not hardcode the .js extension here for whatever (stupid) reason, but thinking about it again that's probably useless, as a reexport can only refer to js files!?

@ef4 ef4 merged commit 6817d46 into embroider-build:main Jun 9, 2022
@ef4
Copy link
Contributor

ef4 commented Jun 9, 2022

Thanks @simonihmig

@ef4 ef4 added the bug Something isn't working label Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants