Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix thread-load JOBS handling/documentation #1191

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

bendemboski
Copy link
Contributor

04d39ba missed one JOBS check, and left it checking for 1 instead of 0, and also didn't update the documentation/comment. Fortunately, it was relatively harmless (related to warming the thread-loader pool, which is just a performance thing) So I consolidated the code into a helper function to ensure consistency, and updated the comment.

04d39ba missed one JOBS check, and left it checking for `1` instead of `0`, and also didn't update the documentation/comment. Fortunately, it was relatively harmless (related to warming the thread-loader pool, which is just a performance thing)  So I consolidated the code into a helper function to ensure consistency, and updated the comment.
@ef4 ef4 merged commit c9ce20e into embroider-build:main Jun 9, 2022
@ef4 ef4 added the bug Something isn't working label Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants