Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated core and compat options #1161

Merged
merged 2 commits into from
Mar 13, 2022

Conversation

bertdeblock
Copy link
Contributor

@bertdeblock bertdeblock commented Mar 11, 2022

I couldn't find these options in the corresponding interfaces or throughout
the rest of the codebase, so I assumed these might be leftovers?

@@ -112,10 +112,7 @@ export function optionsWithDefaults(options?: Options): Required<Options> {
staticHelpers: false,
staticModifiers: false,
staticComponents: false,
packageRules: [],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 100% sure about this one, but it isn't defined in the interface above and it's also a compat option.

@ef4
Copy link
Contributor

ef4 commented Mar 13, 2022

Thanks, I hadn't even noticed that these were lingering.

For those following along at home:

  • optionalComponents is covered instead by safeToIgnore inside packageRules.
  • packageRules is still fully-supported, it's just that it's an option to @embroider/compat, not @embroider/core. You're almost certainly using compat anyway.
  • splitControllers and splitRouteClasses are subsumed by splitAtRoutes, which necessary must handle controllers, route classes, and route templates together.

@ef4 ef4 merged commit 5f72a0a into embroider-build:main Mar 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants