Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix @cached decorator export from fake @glimmer/tracking module #1135

Merged
merged 3 commits into from
Feb 27, 2022

Conversation

NullVoxPopuli
Copy link
Collaborator

@NullVoxPopuli NullVoxPopuli commented Feb 19, 2022

Discovered during: #1132 (comment)

(I put @cached in the wrong spot :( )

@lifeart
Copy link
Collaborator

lifeart commented Feb 20, 2022

@NullVoxPopuli looks like we could use https://github.com/embroider-build/embroider/blob/main/packages/compat/tests/route-split.test.ts as reference for test, in my understanding we could have minimal ember app with cached decorator usage and it's should pass build

@NullVoxPopuli
Copy link
Collaborator Author

🙃
image

@NullVoxPopuli
Copy link
Collaborator Author

Test success:
image

tests/scenarios/scenarios.ts Outdated Show resolved Hide resolved
@ef4 ef4 merged commit 648d38f into embroider-build:main Feb 27, 2022
@NullVoxPopuli NullVoxPopuli deleted the fixed-cached-decorator-export branch February 27, 2022 18:46
@rwjblue rwjblue added the bug Something isn't working label Mar 1, 2022
@rwjblue rwjblue changed the title Fix @cached decorator export from fake @glimmer/tracking module Fix @cached decorator export from fake @glimmer/tracking module Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants