Fix @cached decorator export from fake @glimmer/tracking module
#1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lifeart
approved these changes
Feb 20, 2022
|
@NullVoxPopuli looks like we could use https://github.com/embroider-build/embroider/blob/main/packages/compat/tests/route-split.test.ts as reference for test, in my understanding we could have minimal ember app with cached decorator usage and it's should pass build |
NullVoxPopuli
force-pushed
the
fixed-cached-decorator-export
branch
from
7a944f7
to
03f09b5
Compare
|
🙃 |
|
Test success: |
NullVoxPopuli
force-pushed
the
fixed-cached-decorator-export
branch
from
5102139
to
1c9b310
Compare
ef4
reviewed
Feb 26, 2022
ef4
approved these changes
Feb 26, 2022
NullVoxPopuli
force-pushed
the
fixed-cached-decorator-export
branch
from
c0bcb22
to
d57cadc
Compare
rwjblue
changed the title
@cached decorator export from fake @glimmer/tracking module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered during: #1132 (comment)
(I put
@cachedin the wrong spot :( )