Solve ts related double setComponentTemplate #1134
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #1126
(Only because my reproduction repos cover both TS and template-only)
Reproduction repo: https://github.com/NullVoxPopuli/ember-addon-v2-typescript-demo/
This PR aims to solve the problem discovered here: #1099
Where prior to the changes in this PR, component output for TS files (using rollup-plugin-ts) included two
setComponentTemplate
calls, such as:The line that has:
erroneously has setComponentTemplate doing a self-reference, which wouldn't cause a an error during app boot, but would cause additional boot time for apps (the less to do during boot the bett)