Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only apply ember-power-select compat adapter when using ember-power-select < 5.0.1 #1130

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

betocantu93
Copy link
Contributor

@betocantu93 betocantu93 commented Feb 14, 2022

Based on our conversation and and taking this commit's version as the introduction of "ensure-safe-component", this PR adds semverRange below v5.0.1

@ef4
Copy link
Contributor

ef4 commented Feb 14, 2022

Thanks, have you been able to confirm that this solves your original problem in ember-eui?

@betocantu93
Copy link
Contributor Author

betocantu93 commented Feb 14, 2022

@ef4 yes, I just confirmed it, it works! 🥳 now ember-eui supports staticComponents next milestone v2, thank you!

@ef4 ef4 merged commit e7650f6 into embroider-build:main Feb 14, 2022
@betocantu93 betocantu93 deleted the patch-2 branch February 14, 2022 21:31
@rwjblue rwjblue changed the title restrict semverRange for ember-power-select packageRules Only apply ember-power-select compat adapter when using ember-power-select < 5.0.1 Mar 1, 2022
@rwjblue rwjblue added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants