Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix cacheKeyForTree & OneShot incompatibility" #1117

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Feb 8, 2022

This reverts commit ebe4aed.

This change isn't needed because I eliminated OneShot instead in #1115, so we can keep the per-tree caching, which is closer to what the classic build does.

This reverts commit ebe4aed.

This isn't needed because I eliminated OneShot instead, so I'm bringing it back to maximize compatibility with the old cacheKeyForTree system.
@ef4 ef4 merged commit 7ec162f into main Feb 8, 2022
@ef4 ef4 deleted the restore-cache-key-for-tree branch February 8, 2022 06:21
ef4 added a commit that referenced this pull request Jun 9, 2022
Fixes #1211. This should have been added when HTMLEntrypoint was written, but was missed at that point and didn't actually matter until other changes circa #1117 provided more stable inputs and revealed this state leak.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant