Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the ember-template-compiler to v4.1.0 #1103

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

Windvis
Copy link
Collaborator

@Windvis Windvis commented Feb 3, 2022

I started looking into #1018 again and I noticed the tests failed because the template compiler doesn't support the new helpers yet.

I just plucked this out of the ember-source package of a 4.1.0 Ember app. Let me know if there is a better way to update it 😄.

@Windvis Windvis force-pushed the chore/update-template-compiler branch 2 times, most recently from 58b2b7a to a3fef30 Compare February 3, 2022 20:26
@Windvis
Copy link
Collaborator Author

Windvis commented Feb 4, 2022

The failing check seems unrelated to this change?

connect ECONNREFUSED 52.73.87.228:443

@ef4
Copy link
Contributor

ef4 commented Feb 5, 2022

Yes, that CI failure is something in Github's caching layer as used by the Volta action and it seems to happen about 1% of the time, which means in our suite of 111 jobs it happens once almost every run. 🙃

@ef4
Copy link
Contributor

ef4 commented Feb 5, 2022

Thanks for working on this.

This part of the test suite is lacking a way to test multiple ember versions. Can you verify (at least manually) that these changes to macro-maybe-attrs are compatible with the 3.25-era template-compiler that this PR is replacing?

Ultimately we need to finish moving all the node tests into the tests/scenarios so that they can be run under multiple ember versions.

@Windvis
Copy link
Collaborator Author

Windvis commented Feb 8, 2022

@ef4 The tests still pass with the template compiler of ember 3.25. I can split the loc commit in a separate branch and PR it on its own so that it can be verified through CI?

This allows us to add tests for the new `helper` and `modifier` helpers.
@Windvis Windvis force-pushed the chore/update-template-compiler branch from 42d8dc4 to ff67415 Compare February 10, 2022 09:45
@ef4 ef4 merged commit e85e21e into embroider-build:main Feb 15, 2022
@ef4
Copy link
Contributor

ef4 commented Feb 15, 2022

Thanks, nice work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants