Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure OneShot tmp dir cleanup #1084

Merged
merged 2 commits into from
Jan 21, 2022
Merged

Conversation

krisselden
Copy link
Contributor

Move builder creation into build() call because when the builder is created it creates temp dirs and if you load the build file but don't build it never cleans up.

Move builder creation into build() call because
when the builder is created it creates temp dirs.

If you load the build file but don't build it never
cleans up.
@ef4 ef4 merged commit b9f0f31 into embroider-build:main Jan 21, 2022
@ef4 ef4 added the bug Something isn't working label Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants