Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

native v2 addons can always import from NPM #1075

Merged
merged 1 commit into from
Jan 13, 2022
Merged

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Jan 13, 2022

This check was intended to prevent v1 addons from accidentally gaining new semantics under embroider, but it needs to be relaxed for v2 addons which are supposed to be able to import from NPM without any special dependency on ember-auto-import.

This bug doesn't actually fail for static imports, because those are allowed to fall through to webpack and it finds them anyway. But for dynamic imports, it causes us to insert our runtime error.

This check was intended to prevent v1 addons from accidentally gaining new semantics under embroider, but it needs to be relaxed for v2 addons which *are* supposed to be able to import from NPM without any special dependency on ember-auto-import.
@ef4 ef4 merged commit 42baeb0 into master Jan 13, 2022
@ef4 ef4 deleted the allow-v2-addon-import branch January 13, 2022 07:51
@rwjblue rwjblue added the bug Something isn't working label Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants