Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ember-cli-babel optimization #1042

Merged
merged 1 commit into from
Dec 8, 2021
Merged

Fix ember-cli-babel optimization #1042

merged 1 commit into from
Dec 8, 2021

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Dec 8, 2021

Fix for #1041

We can't just ignore all the output of every copy of ember-cli-babel. Some copy might be trying to emit the babel polyfills into vendor.

We can still optimize, but we need to do it by using knowledge of which copy would win to provide the vendor tree and ensure that only that one runs.

@ef4 ef4 merged commit d0fddf9 into master Dec 8, 2021
@ef4 ef4 deleted the optimize-ember-cli-babel2 branch December 8, 2021 05:39
@rwjblue rwjblue added the bug Something isn't working label Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants