Don't resolve built-in components when used with the component helper #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work, thanks. |
Windvis
commented
Nov 21, 2021
| @@ -731,6 +731,11 @@ export default class CompatResolver implements Resolver { | |||
| from | |||
| ); | |||
| } | |||
|
|
|||
| if (builtInComponents.includes(component.path)) { | |||
There was a problem hiding this comment.
Hmm, I just realized that early returning here will prevent people from "shadowing" built-in components by creating components with the same name in their project or addon. It doesn't seem like a good thing to do and I'm not sure if it's officially supported but it does seem to work (tested in Ember twiddle).
Is that something that needs to work under Embroider?
There was a problem hiding this comment.
as I understand, we could check it using 'tryComponent' method
Windvis
force-pushed
the
fix/component-helper-resolver-ignore-built-ins
branch
from
e5f9a23
to
b4c3b10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the code that handles the component helper doesn't ignore the built-in components like the other component resolving code does.
Closes #815