@embroider/router Ember 4 CI job compatibility
#1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windvis
force-pushed
the
fix/router/blueprint-ember-4-compatibility
branch
from
1e7b27d
to
ea03e93
Compare
|
@Windvis I enabled CI for your PR. It looks fine to me, but one test related to your (refactored!) |
This is a requirement for the ember-release CI job.
This fixes deprecation warnings for features that are removed in Ember v4.
Windvis
force-pushed
the
fix/router/blueprint-ember-4-compatibility
branch
from
ea03e93
to
6d341d3
Compare
Windvis
commented
Nov 23, 2021
| function hasComponentTemplate(name) { | ||
| return Boolean(requirejs.entries[`${ENV.modulePrefix}/templates/components/${name}`]); | ||
| function hasComponent(name) { | ||
| return Boolean(requirejs.entries[`${ENV.modulePrefix}/components/${name}`]); |
There was a problem hiding this comment.
@simonihmig I updated the path and renamed the function. Should be good now! 🙏
Windvis
changed the title
@embroider/router Ember 4 compatibility@embroider/router Ember 4 CI job compatibility
|
Thanks, nice work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the blueprint to the latest version and adds some other changes to make the tests succeed on Ember v4.
Closes #1024
Closes #1028