Fix exclusion of the hbs file of the pod components when podModulePrefix === ''
#1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
..is properly included when podModulePrefix === '' This is a reproduction for issue 987.
The hbs files of a pod component was excluded from the bundle. As they are not referenced by their corresponding JS component, they need to be included. We make the assumption that a pod component's hbs file is always named `template.hbs`.
dcyriller
changed the title
dcyriller
changed the title
podModulePrefix === ''
lifeart
approved these changes
Oct 19, 2021
|
Thanks, nice work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug
When using a pod component in an app configured with
podModulePrefix === '', the hbs file of the component was not included in the build.This PR adds a failing test and proposes a fix. It would address #987
The fix' assumption
This fix makes the assumpation that the hbs file of a pod component will always be named
template.hbs. This is consistent with ember-cli documentation and blueprints. It seems consistent with ember-cli source code as well?