Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove command documentation from addon-shim package #1005

Merged
merged 1 commit into from
Oct 15, 2021
Merged

Conversation

simonihmig
Copy link
Collaborator

As the command has been moved to addon-dev.

As the command has been moved to `addon-dev`.
@ef4
Copy link
Contributor

ef4 commented Oct 15, 2021

Good catch, thanks.

(And it looks like I need to figure out what dependency suddenly broke a lot of ci jobs, but that shouldn't block this docs pr.)

@ef4 ef4 merged commit 1c4d39c into master Oct 15, 2021
@ef4 ef4 deleted the simonihmig-patch-1 branch October 15, 2021 14:07
@simonihmig
Copy link
Collaborator Author

(And it looks like I need to figure out what dependency suddenly broke a lot of ci jobs, but that shouldn't block this docs pr.)

Yeah, this already cost me some hours today. It seems to be socketio/socket.io#4121, which basically makes all ember tests that have no locked dependencies fail. We can temporarily fix this by pinning socket.io to 4.2.0 using yarn resolutions, or just wait for @chriskrycho's fix to get merged and released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants