Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove skipBabel option #1942

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

BlueCutOfficial
Copy link
Collaborator

@BlueCutOfficial BlueCutOfficial commented May 22, 2024

Follows #1939,
Fixes #1963,

As explained in the related issue, this PR should be merged only after #1962 is implemented and merged because #1962 is the piece that introduce the usage of babel.config.cjs to achieve what was previously achieved by the usage of skipBabel. If we merge the present PR before #1962 is done, we remove the possibility to apply some Babel filters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the _babel_filter_ file and skipBabel option from Embroider options
1 participant