Conversation
This implements the `implicit-modules` feature from the v2 addon spec. The motivation is deprecating ember-source's traditional AMD bundles. Today on classic builds, even though ember-source is a v2 addon, most of its modules side-step ember-auto-import and still get included as part of those AMD bundles. We're making an optional feature to stop doing that, and we're going to deprecate running with that feature disabled. In this mode, ember-source will need to use `implicit-modules` to continue registering all its usual modules with the runtime loader. Otherwise, modules that are only used by a v1 addon that lacks ember-auto-import would be dropped from the build.
5 tasks
ef4
force-pushed
the
implicit-modules-support
branch
from
978d8de to
483884a
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the
implicit-modulesfeature from the v2 addon spec.The motivation is deprecating ember-source's traditional AMD bundles. Today on classic builds, even though ember-source is a v2 addon, most of its modules side-step ember-auto-import and still get included as part of those AMD bundles. We're making an optional feature to stop doing that, and we're going to deprecate running with that feature disabled.
In this mode, ember-source will need to use
implicit-modulesto continue registering all its usual modules with the runtime loader. Otherwise, modules that are only used by a v1 addon that lacks ember-auto-import would be dropped from the build.