Skip to content

Commit

Permalink
Merge pull request #575 from ef4/fix-canary
Browse files Browse the repository at this point in the history
Update blueprints for ember canary compat
  • Loading branch information
ef4 authored Apr 3, 2023
2 parents a0a29b2 + fe4f849 commit 22ffabc
Show file tree
Hide file tree
Showing 8 changed files with 9,640 additions and 7,685 deletions.
36 changes: 18 additions & 18 deletions .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -74,21 +74,21 @@ jobs:
run: npm run test:node
working-directory: packages/ember-auto-import

ie:
name: ie11 safety
runs-on: windows-latest
steps:
- uses: actions/checkout@v1
- uses: volta-cli/action@v4
with:
node-version: '14'
- uses: actions/cache@v2
with:
path: ~/.npm
key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
${{ runner.os }}-node-
- run: npm install
- name: test
run: 'npm run test -- --filter browser-targets-transpiled:'
working-directory: test-scenarios
# ie:
# name: ie11 safety
# runs-on: windows-latest
# steps:
# - uses: actions/checkout@v1
# - uses: volta-cli/action@v4
# with:
# node-version: '14'
# - uses: actions/cache@v2
# with:
# path: ~/.npm
# key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
# restore-keys: |
# ${{ runner.os }}-node-
# - run: npm install
# - name: test
# run: 'npm run test -- --filter browser-targets-transpiled:'
# working-directory: test-scenarios
17,259 changes: 9,601 additions & 7,658 deletions package-lock.json

Large diffs are not rendered by default.

7 changes: 4 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
"scripts": {
"test": "cd test-scenarios && npm run test",
"watch": "cd packages/ember-auto-import && npm run compile -- --watch",
"prepare": "cd packages/ember-auto-import && npm run compile",
"nom": "rm -rf node_modules packages/*/node_modules test-scenarios/node_modules types/*/node_modules"
"nom": "rm -rf node_modules packages/*/node_modules test-scenarios/node_modules types/*/node_modules",
"postinstall": "patch-package"
},
"workspaces": [
"packages/*",
Expand All @@ -20,10 +20,11 @@
"eslint-plugin-ember": "^5.0.0",
"eslint-plugin-node": "^6.0.1",
"eslint-plugin-prettier": "^3.3.0",
"patch-package": "^6.5.1",
"prettier": "^2.2.1"
},
"volta": {
"node": "14.16.0",
"node": "14.21.3",
"npm": "8.3.0"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/addon-template/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
"devDependencies": {
"@babel/core": "^7.19.3",
"@ember/optional-features": "^2.0.0",
"@ember/string": "^3.0.1",
"@ember/test-helpers": "^2.6.0",
"@embroider/test-setup": "npm:@embroider/test-setup@latest",
"@glimmer/component": "^1.0.4",
Expand All @@ -43,7 +44,6 @@
"ember-cli-sri": "^2.1.1",
"ember-cli-terser": "^4.0.2",
"ember-disable-prototype-extensions": "^1.1.3",
"ember-export-application-global": "^2.0.1",
"ember-load-initializers": "^2.1.2",
"ember-qunit": "^5.1.5",
"ember-resolver": "^8.0.3",
Expand Down
4 changes: 2 additions & 2 deletions packages/app-template/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
"devDependencies": {
"@babel/core": "^7.19.3",
"@ember/optional-features": "^2.0.0",
"@ember/string": "^3.0.1",
"@ember/test-helpers": "^2.6.0",
"@glimmer/component": "^1.0.4",
"@glimmer/tracking": "^1.0.4",
Expand All @@ -38,7 +39,6 @@
"ember-cli-sri": "^2.1.1",
"ember-cli-terser": "^4.0.2",
"ember-decorators": "^3.1.0",
"ember-export-application-global": "^2.0.1",
"ember-load-initializers": "^2.1.2",
"ember-qunit": "^5.1.5",
"ember-resolver": "^8.0.3",
Expand All @@ -64,7 +64,7 @@
"edition": "octane"
},
"volta": {
"node": "14.16.0",
"node": "14.21.3",
"npm": "8.3.0"
}
}
2 changes: 1 addition & 1 deletion packages/ember-auto-import/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@
]
},
"volta": {
"node": "14.16.0",
"node": "14.21.3",
"npm": "8.3.0"
}
}
11 changes: 11 additions & 0 deletions patches/fastboot+4.1.0.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
diff --git a/node_modules/fastboot/src/fastboot-info.js b/node_modules/fastboot/src/fastboot-info.js
index 50b181b..f330596 100644
--- a/node_modules/fastboot/src/fastboot-info.js
+++ b/node_modules/fastboot/src/fastboot-info.js
@@ -38,6 +38,5 @@ module.exports = class FastBootInfo {
*/
register(instance) {
instance.register('info:-fastboot', this, { instantiate: false });
- instance.inject('service:fastboot', '_fastbootInfo', 'info:-fastboot');
}
};
4 changes: 2 additions & 2 deletions test-scenarios/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"ember-cli-latest": "npm:ember-cli@latest",
"ember-cli-beta": "npm:ember-cli@beta",
"ember-cli": "git+https://github.com/ember-cli/ember-cli#master",
"ember-cli-fastboot": "npm:ember-cli-fastboot@3.2.0-beta.5",
"ember-cli-fastboot": "npm:ember-cli-fastboot@^4.1.0",
"ember-cli-typescript-2": "npm:ember-cli-typescript@^2.0.0-beta.3",
"ember-cli-typescript-3": "npm:ember-cli-typescript@^3.0.0",
"ember-cli-typescript-4": "npm:ember-cli-typescript@^4.0.0-alpha.1",
Expand All @@ -51,7 +51,7 @@
"webpack": "^5.31.0"
},
"volta": {
"node": "14.16.0",
"node": "14.21.3",
"npm": "8.3.0"
}
}

0 comments on commit 22ffabc

Please sign in to comment.