Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add issue read permission to action #133

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Add issue read permission to action #133

merged 1 commit into from
Jul 31, 2024

Conversation

wagenet
Copy link
Contributor

@wagenet wagenet commented Jul 30, 2024 •
edited
Loading

I discovered that this was needed when setting up release-plan in a private repo. For public repos, anyone can read so this isn't necessary.

NullVoxPopuli
NullVoxPopuli approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no downside to having this specified for public repos 🎉

@mansona mansona added the enhancement New feature or request label Jul 31, 2024
@mansona mansona merged commit 8952a04 into embroider-build:main Jul 31, 2024
6 checks passed
@github-actions github-actions bot mentioned this pull request Jul 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NullVoxPopuli NullVoxPopuli NullVoxPopuli approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wagenet @NullVoxPopuli @mansona