Document API methods (Closes #45) #57
Conversation
gitKrystan
force-pushed
the
api-docs
branch
2 times, most recently
from
1659b17
to
dc380f3
Compare
| let output = p.process('<template>Hi</template>'); | ||
| ``` | ||
|
|
||
| ### `Preprocessor.parse(src: string, filename?: string): Parsed[];` |
There was a problem hiding this comment.
I didn't document what adding the filename does bc I don't know the answer to that.
There was a problem hiding this comment.
It makes the error messages nicer if you get a parse error.
There was a problem hiding this comment.
Any reason not to pass this as an option to the generated template() so it ends up in the metadata of the ultimately compiled template?
There was a problem hiding this comment.
We need to do some design here. The old concept of template module names doesn't really map to template tag.
Templates and files are no longer one to one. It would be easy to produce a very confusing component tree in the inspector for example where multiple layers of components all have "the same name" because they're defined in the same file.
Classically the module names were ember's weird module namespace. Not real file names. If we use real file names they get unwieldy quickly and leak system information. Inventing a mapping requires design.
I really think we need to address glimmer stack debugging in a holistic way. We need to map to your actual template, not just the file the template is in.
No description provided.