Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release-it #33

Merged
merged 4 commits into from
Oct 2, 2023
Merged

Add release-it #33

merged 4 commits into from
Oct 2, 2023

Conversation

mansona
Copy link
Member

@mansona mansona commented Oct 2, 2023

This is a custom setup that requires you to create the tag manually after a PR is merged (so that we can keep branch protections)

@mansona mansona requested a review from a team October 2, 2023 14:36

## Tag and Release

Once your PR that updates the Changelog and bumps the version is released you need to tag that commit and push that tag to github.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need to be separate from npx release-it? or is it "better"? to do it this way for some reason?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we don't do this then only admins would be able to do a release of content-tag, rather than people who have merge permissions. This is because you can't push directly to the protected branch master

You can push tags tho

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

legit, thanks!

@mansona mansona merged commit 2f2893b into main Oct 2, 2023
1 check passed
@mansona mansona deleted the release-it branch October 2, 2023 15:13
@ef4
Copy link
Collaborator

ef4 commented Oct 6, 2023

I just ran npx release-it and it created and pushed a commit directly to main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants