-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release-it #33
Add release-it #33
Conversation
|
||
## Tag and Release | ||
|
||
Once your PR that updates the Changelog and bumps the version is released you need to tag that commit and push that tag to github. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this need to be separate from npx release-it
? or is it "better"? to do it this way for some reason?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we don't do this then only admins would be able to do a release of content-tag, rather than people who have merge permissions. This is because you can't push directly to the protected branch master
You can push tags tho
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
legit, thanks!
I just ran |
This is a custom setup that requires you to create the tag manually after a PR is merged (so that we can keep branch protections)