fix: cross-browser test determinism and missing FetchTransport coverage#1430
Merged
Merged
Conversation
pablomatiasgomez
approved these changes
Jul 16, 2026
Contributor
Chrome DevTools Protocol Tracing (Script: 113.03ms, Heap: 13.14MB)
Lighthouse (Script Eval: 128.13ms)
Platform Tests (vite-7 es2015 gzip: 70.77KB)vite-6 Platform Tests
vite-7 Platform Tests
webpack-5 Platform Tests
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1430 +/- ##
==========================================
+ Coverage 96.74% 96.87% +0.12%
==========================================
Files 233 233
Lines 10183 10183
Branches 1437 1440 +3
==========================================
+ Hits 9852 9865 +13
+ Misses 329 316 -13
Partials 2 2 🚀 New features to boost your workflow:
|
…nd legacy-timeout paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem is this solving?
Two unrelated test gaps found while working in this area:
EmbracePageManager.test.ts's soft-navigation zero-time tests were flaky on Firefox and WebKit:FakeNavigation.fire()constructed acurrententrychangeEventand invoked listeners directly instead of dispatching it through a realEventTarget. Some engines only populateEvent.timeStampon actual dispatch, leaving it at0otherwise.getZeroTime()before/after with no time gap in between, which could land in the same rounded timestamp bucket under WebKit's coarser timer resolution.