Skip to content

chore(biome): mark nested configs as non-root#1399

Merged
overbalance merged 5 commits into
mainfrom
overbalance/migrate-biome
Jul 6, 2026
Merged

chore(biome): mark nested configs as non-root#1399
overbalance merged 5 commits into
mainfrom
overbalance/migrate-biome

Conversation

@overbalance

@overbalance overbalance commented Jun 30, 2026

Copy link
Copy Markdown
Member

What problem is this solving?

In the newest version, Biome requires nested biome.jsonc files that extend the root config to explicitly opt out of being treated as roots themselves.

Short description of the changes

Add "root": false to the three nested Biome configs (packages/web-sdk/src, tests/integration, tests/performance) so they are recognized as non-root configs extending the workspace root.

This codemod was by npx biome migrate, not manual intervention.

How was this tested?

npm run lint from the repo root.

Checklist

  • Changes are covered by existing lint config

@github-actions

github-actions Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor
Chrome DevTools Protocol Tracing (Script: 116.25ms, Heap: 13.52MB)
Number of Requests Size of Requests Script Duration Task Duration Heap Used Size
Requests +13 requests +41.85 KB
Page Loaded +19.92 ms +5.90 ms +1.17 MB
Generate 100 fetch requests +20.49 ms +63.18 ms +1.63 MB
Generate 100 XHR requests +42.18 ms +105.97 ms +2.83 MB
Click 100 buttons and generate 100 logs +23.81 ms +54.46 ms +2.35 MB
Throw a 100 exceptions +0.07 ms +29.63 ms +2.33 MB
End Session +9.79 ms +37.89 ms +3.21 MB
Total +13 requests +41.85 KB +116.25 ms +297.04 ms +13.52 MB
Lighthouse (Script Eval: 133.28ms)
Difference Description
Total Blocking Time +3 ms Difference in Total Blocking Time: Sum of all time periods between FCP and Time to Interactive, when task length exceeded 50ms, expressed in milliseconds. Learn more about the Total Blocking Time metric.
Main Thread Time +100.18 ms Difference in Main Thread Time: Consider reducing the time spent parsing, compiling and executing JS. You may find delivering smaller JS payloads helps with this. Learn how to minimize main-thread work
Script Evaluation Time +133.28 ms Difference in Script Evaluation Time: Consider reducing the time spent parsing, compiling, and executing JS. You may find delivering smaller JS payloads helps with this. Learn how to reduce Javascript execution time.
Platform Tests (vite-7 es2015 gzip: 69.66KB)

vite-6 Platform Tests

Total Uncompressed Size Total Gzip Size
vite-6 - es2015 +203.00 KB +69.70 KB

vite-7 Platform Tests

Total Uncompressed Size Total Gzip Size
vite-7 - es2015 +203.00 KB +69.66 KB

webpack-5 Platform Tests

Total Uncompressed Size Total Gzip Size
webpack-5 - es2015 0 KB 0 KB

@overbalance
overbalance enabled auto-merge (squash) June 30, 2026 18:45
@overbalance
overbalance merged commit 41db7df into main Jul 6, 2026
20 checks passed
@overbalance
overbalance deleted the overbalance/migrate-biome branch July 6, 2026 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants