Skip to content

test(sdk): replace flaky timeout with localStorage polling #1053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
overbalance merged 1 commit into from
Jan 12, 2026
Merged

test(sdk): replace flaky timeout with localStorage polling #1053

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 30 additions & 9 deletions src/sdk/initSDK.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1647,6 +1647,24 @@ describe('isolated instances', () => {
fakeFetchRestore();
});

// Poll for localStorage keys to be set, avoiding flaky fixed timeouts
const waitForLocalStorageKeys = async (
keys: string[],
timeout = 1000,
): Promise<void> => {
const start = Date.now();
while (Date.now() - start < timeout) {
if (keys.every((key) => localStorage.getItem(key) !== null)) {
return;
}
await new Promise((r) => setTimeout(r, 5));
}
const missing = keys.filter((key) => localStorage.getItem(key) === null);
throw new Error(
`Timed out waiting for localStorage keys: ${missing.join(', ')}`,
);
};

it('should allow multiple isolated instances', () => {
const firstSDKInstance = initSDK({
logExporters: [logExporter],
Expand Down Expand Up @@ -1807,9 +1825,11 @@ describe('isolated instances', () => {
void expect(secondSDKInstance, 'second SDK instance failed to initialize')
.not.to.be.false;

// Need to give time for the remote config to be fetched and then parsed
await new Promise((r) => setTimeout(r, 1));
await new Promise((r) => setTimeout(r, 1));
// Wait for remote config to be fetched and stored for both instances
await waitForLocalStorageKeys([
'app11_embrace_remote_config',
'app22_embrace_remote_config',
]);

// First instance using namespaced storage
expect(!!localStorage.getItem('app11_embrace_user_id')).to.equal(
Expand Down Expand Up @@ -1888,9 +1908,8 @@ describe('isolated instances', () => {
void expect(firstSDKInstance).not.to.be.false;
void expect(secondSDKInstance).not.to.be.false;

// Need to give time for the remote config to be fetched and then parsed
await new Promise((r) => setTimeout(r, 1));
await new Promise((r) => setTimeout(r, 1));
// Wait for remote config to be fetched and stored (only second instance has appID)
await waitForLocalStorageKeys(['app22_embrace_remote_config']);

// Second instance using namespaced storage
expect(!!localStorage.getItem('app22_embrace_user_id')).to.equal(true);
Expand Down Expand Up @@ -1929,9 +1948,11 @@ describe('isolated instances', () => {
void expect(firstSDKInstance).not.to.be.false;
void expect(secondSDKInstance).not.to.be.false;

// Need to give time for the remote config to be fetched and then parsed
await new Promise((r) => setTimeout(r, 1));
await new Promise((r) => setTimeout(r, 1));
// Wait for remote config to be fetched and stored for both instances
await waitForLocalStorageKeys([
'embrace_remote_config',
'app22_embrace_remote_config',
]);

// Second instance using namespaced storage
expect(!!localStorage.getItem('app22_embrace_user_id')).to.equal(true);
Expand Down
Loading