Skip to content

fix(otel): patch require in protobuf#1025

Merged
overbalance merged 4 commits intomainfrom
overbalance/patch-require-in-protobuf
Dec 16, 2025
Merged

fix(otel): patch require in protobuf#1025
overbalance merged 4 commits intomainfrom
overbalance/patch-require-in-protobuf

Conversation

@overbalance
Copy link
Copy Markdown
Member

@overbalance overbalance commented Dec 16, 2025

What problem is this solving?

The @protobufjs/inquire package uses an obfuscated eval() to dynamically require modules, which breaks CSP policies and causes bundler issues.

Short description of changes

  • Add patch for @protobufjs/inquire@1.1.0 replacing eval-based require with direct require
  • Document patch with upstream issue link and removal criteria
  • Run patch-package in sdk:compile since ignore-scripts=true prevents prepare from running

Testing

  • npm run lint && npm run compile passes
  • Patch applies cleanly via patch-package

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 16, 2025

Chrome DevTools Protocol Tracing (Script: 110.58ms, Heap: 14.08MB)
Number of Requests Size of Requests Script Duration Task Duration Heap Used Size
Requests +3 requests +29.67 KB
Page Loaded +16.02 ms +15.31 ms +0.95 MB
Generate 100 fetch requests +15.86 ms +67.66 ms +2.19 MB
Generate 100 XHR requests +38.49 ms +105.63 ms +2.36 MB
Click 100 buttons and generate 100 logs +30.83 ms +39.32 ms +3.00 MB
Throw a 100 exceptions +1.77 ms +21.12 ms +2.46 MB
End Session +7.63 ms +16.05 ms +3.14 MB
Total +3 requests +29.67 KB +110.58 ms +265.09 ms +14.08 MB
Lighthouse (Script Eval: 53.10ms)
Difference Description
Total Blocking Time 0 ms Difference in Total Blocking Time: Sum of all time periods between FCP and Time to Interactive, when task length exceeded 50ms, expressed in milliseconds. Learn more about the Total Blocking Time metric.
Main Thread Time +65.46 ms Difference in Main Thread Time: Consider reducing the time spent parsing, compiling and executing JS. You may find delivering smaller JS payloads helps with this. Learn how to minimize main-thread work
Script Evaluation Time +53.10 ms Difference in Script Evaluation Time: Consider reducing the time spent parsing, compiling, and executing JS. You may find delivering smaller JS payloads helps with this. Learn how to reduce Javascript execution time.
Platform Tests (vite-7 gzip: 47.99KB)

vite-7 Platform Tests

Total Uncompressed Size Total Gzip Size
vite-7 - esnext +164.67 KB +47.99 KB
vite-7 - es2015 +171.51 KB +49.67 KB

vite-otel-latest Platform Tests

Total Uncompressed Size Total Gzip Size
vite-otel-latest - esnext +163.74 KB +49.69 KB
vite-otel-latest - es2015 +170.50 KB +51.32 KB

webpack-5 Platform Tests

Total Uncompressed Size Total Gzip Size
webpack-5 - esnext +121.11 KB +43.17 KB
webpack-5 - es2015 +122.22 KB +44.65 KB

@overbalance overbalance force-pushed the overbalance/patch-require-in-protobuf branch from 66f0cd2 to 4c406ac Compare December 16, 2025 18:56
@overbalance overbalance force-pushed the overbalance/patch-require-in-protobuf branch from 4c406ac to 740327b Compare December 16, 2025 19:00
Base automatically changed from overbalance/refactor-iife-build to main December 16, 2025 19:14
Signed-off-by: Jared Freeze <overbalance@users.noreply.github.com>
@overbalance overbalance marked this pull request as ready for review December 16, 2025 19:15
@overbalance overbalance requested a review from a team as a code owner December 16, 2025 19:15
@overbalance overbalance merged commit e3b8003 into main Dec 16, 2025
17 checks passed
@overbalance overbalance deleted the overbalance/patch-require-in-protobuf branch December 16, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants