refactor(web-vitals): require explicit trackingLevel for all metrics#1024
Merged
overbalance merged 1 commit intomainfrom Dec 19, 2025
Merged
refactor(web-vitals): require explicit trackingLevel for all metrics#1024overbalance merged 1 commit intomainfrom
overbalance merged 1 commit intomainfrom
Conversation
Contributor
Chrome DevTools Protocol Tracing (Script: 107.10ms, Heap: 13.58MB)
Lighthouse (Script Eval: 46.02ms)
Platform Tests (vite-7 gzip: 47.99KB)vite-7 Platform Tests
vite-otel-latest Platform Tests
webpack-5 Platform Tests
|
7c88baa to
ac8cf6b
Compare
jpmunz
approved these changes
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem is this solving?
Makes the trackingLevel option require explicit 'all' value to track FCP and TTFB, aligning with test expectations.
Short description of changes
trackingLevel === 'core'totrackingLevel === 'all'trackingLevel: 'all'Testing