Adds onChange #50

dyarfaradj · 2019-12-04T21:59:57Z

Adds onChange

embiem

Please also update the defaultProps list in the README.md to include onChange.

Thank you!

embiem · 2019-12-29T20:44:18Z

src/index.js

@@ -444,7 +453,7 @@ export default class extends PureComponent {
      const pointer = this.lazy.getPointerCoordinates();
      const brush = this.lazy.getBrushCoordinates();

-      this.drawInterface(this.ctx.interface, pointer, brush);
+      // this.drawInterface(this.ctx.interface, pointer, brush);


Suggested change

// this.drawInterface(this.ctx.interface, pointer, brush);

this.drawInterface(this.ctx.interface, pointer, brush);

Please uncomment this line again, otherwise the catenary and draw position is not shown.

I'm not able to add these changes since it's not my work. You could just make a commit after you've merged this. I have opened a pr for the readme: #54

sowcow added 2 commits October 19, 2019 13:09

dont-draw-interface

92c6ae7

trigger-on-change

0c32ec1

dyarfaradj mentioned this pull request Dec 4, 2019

Question: any way to receive events from the canvas draw and pass out the updated object? #39

Closed

embiem suggested changes Dec 29, 2019

View reviewed changes

embiem merged commit d5af74c into embiem:develop Dec 29, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds onChange #50

Adds onChange #50

dyarfaradj commented Dec 4, 2019

embiem left a comment

embiem Dec 29, 2019

dyarfaradj Dec 29, 2019

embiem Dec 29, 2019

	// this.drawInterface(this.ctx.interface, pointer, brush);
	this.drawInterface(this.ctx.interface, pointer, brush);

Adds onChange #50

Adds onChange #50

Conversation

dyarfaradj commented Dec 4, 2019

embiem left a comment

Choose a reason for hiding this comment

embiem Dec 29, 2019

Choose a reason for hiding this comment

dyarfaradj Dec 29, 2019

Choose a reason for hiding this comment

embiem Dec 29, 2019

Choose a reason for hiding this comment