Skip to content

Add reflector logger level override env var#624

Closed
komapa wants to merge 2 commits intoemberstack:mainfrom
seatgeek:fix/debug-logging-596
Closed

Add reflector logger level override env var#624
komapa wants to merge 2 commits intoemberstack:mainfrom
seatgeek:fix/debug-logging-596

Conversation

@komapa
Copy link
Copy Markdown
Contributor

@komapa komapa commented Mar 27, 2026

Fixes #596

@github-actions
Copy link
Copy Markdown

Automatically marked as stale due to no recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions Bot added the stale label Apr 14, 2026
@komapa
Copy link
Copy Markdown
Contributor Author

komapa commented Apr 14, 2026

I hope we can still get this merged!

@github-actions github-actions Bot removed the stale label Apr 15, 2026
@winromulus
Copy link
Copy Markdown
Contributor

Hey @komapa — thanks for pushing on this and for the patience while it sat on my plate.

After digging into the root cause, I went with a slightly different approach on main. The reason minimumLevel: Debug wasn't producing debug logs turned out to be the "ES.Kubernetes.Reflector": "Information" entry in appsettings.json's MinimumLevel:Override block. Every logger in the project has a SourceContext starting with ES.Kubernetes.Reflector.*, so that line was winning the longest-prefix match and pinning all project logs at Information regardless of what Helm passed in via ES_Serilog__MinimumLevel__Default.

The fix on main removes that override entry and changes MinimumLevel:Default from Verbose to Information. With those two changes, the existing ES_Serilog__MinimumLevel__Default env var flows through to project loggers exactly as users expect — no second env var needed, and appsettings.json stays intuitive for the next reader.

Your channel bump from 256 → 1024 also landed on main — good catch on that one, the smaller buffer was a real bottleneck.

Closing this as superseded. Genuinely appreciate the contribution and the nudge on #596 — it had been sitting for a while and you got it moving. Hope to see more PRs from you.

@winromulus winromulus closed this Apr 21, 2026
@komapa
Copy link
Copy Markdown
Contributor Author

komapa commented Apr 22, 2026

Hey @komapa — thanks for pushing on this and for the patience while it sat on my plate.

After digging into the root cause, I went with a slightly different approach on main. The reason minimumLevel: Debug wasn't producing debug logs turned out to be the "ES.Kubernetes.Reflector": "Information" entry in appsettings.json's MinimumLevel:Override block. Every logger in the project has a SourceContext starting with ES.Kubernetes.Reflector.*, so that line was winning the longest-prefix match and pinning all project logs at Information regardless of what Helm passed in via ES_Serilog__MinimumLevel__Default.

The fix on main removes that override entry and changes MinimumLevel:Default from Verbose to Information. With those two changes, the existing ES_Serilog__MinimumLevel__Default env var flows through to project loggers exactly as users expect — no second env var needed, and appsettings.json stays intuitive for the next reader.

Your channel bump from 256 → 1024 also landed on main — good catch on that one, the smaller buffer was a real bottleneck.

Closing this as superseded. Genuinely appreciate the contribution and the nudge on #596 — it had been sitting for a while and you got it moving. Hope to see more PRs from you.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Debug logging not working (tested on helm chart 10.0.9)

2 participants