More robust type detection in get-key.js

[hypothete]

Recently on our Ember app we've been having issues using ember-data-storefront to retrieve some - but not all - items from the shoebox. We determined that the frontend and Fastboot were able to generate the appropriate keys for retrieval, but ember-data-storefront was sometimes trying to fetch with malformed keys. We tracked the bug down to the object constructor comparison in get-key.js, where sometimes our params constructor appeared like so instead of as the Object constructor:

[Function: Object] {
  ___dart_isolate_tags_: [Object: null prototype] { _ZxYxX_0_: 1 }
}

This appears to have come from ember-cli-sass using dart-sass, which pollutes the Object constructor. We still haven't determined why this only affects some uses of cacheKey().

Granted, this bug is not ember-data-storefront's fault, but with a small change to get-key.js the library can validate arrays and objects without comparing constructors. Would you be supportive of this change?

[ryanto]

Awesome!

I would have never been able to debug this :D so thanks for digging in and getting it solved.

I'll get this merged and released tomorrow.

[hypothete]

Thanks @ryanto ! Looking forward to your release.

[ryanto]

Ok released as v0.17.2! Thanks again for getting this fixed.