fix ember-try scenarios

embermap · Sep 25, 2024 · 653f59b · 653f59b
1 parent 84ce9b1
commit 653f59b
Show file tree

Hide file tree

Showing 3 changed files with 1,002 additions and 2,380 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -86,7 +86,7 @@ jobs:
           - ember-lts-4.8
           - ember-lts-4.12
           - ember-lts-5.4
-          - ember-lts-4.8
+          - ember-lts-5.8
           - fastboot-1.2
           - fastboot-2.0
           - fastboot-3.0

diff --git a/tests/dummy/config/ember-try.js b/tests/dummy/config/ember-try.js
@@ -11,6 +11,7 @@ module.exports = async function () {
         name: 'ember-lts-3.28',
         npm: {
           devDependencies: {
+            'ember-cli': '~4.12.0',
             'ember-source': '~3.28.0',
           },
         },
@@ -62,10 +63,18 @@ module.exports = async function () {
             fastboot: '~1.2.1',
           },
           devDependencies: {
+            '@ember/test-helpers': '^2.9.3',
+            'ember-cli': '~4.12.0',
             'ember-source': '~3.20.7',
             'ember-data': '~3.20.5',
             'ember-qunit': '^5.1.5',
           },
+          // ember-cli-fastboot v3 incorrectly passed args to json-stable-stringify
+          // which results in TypeError in latest versions of json-stable-stringify,
+          // hence pinning.
+          resolutions: {
+            'json-stable-stringify': '1.0.2',
+          },
         },
       },
       {
@@ -75,11 +84,19 @@ module.exports = async function () {
             fastboot: '~2.0.3',
           },
           devDependencies: {
+            '@ember/test-helpers': '^2.9.3',
+            'ember-cli': '~4.12.0',
             'ember-cli-fastboot': '^2.0.0',
             'ember-data': '~3.20.5',
             'ember-qunit': '^5.1.5',
             'ember-source': '~3.20.7',
           },
+          // ember-cli-fastboot v3 incorrectly passed args to json-stable-stringify
+          // which results in TypeError in latest versions of json-stable-stringify,
+          // hence pinning.
+          resolutions: {
+            'json-stable-stringify': '1.0.2',
+          },
         },
       },
       {
@@ -90,6 +107,13 @@ module.exports = async function () {
           },
           devDependencies: {
             'ember-cli-fastboot': '^3.0.0',
+            'ember-source': '~4.12.0',
+          },
+          // ember-cli-fastboot v3 incorrectly passed args to json-stable-stringify
+          // which results in TypeError in latest versions of json-stable-stringify,
+          // hence pinning.
+          resolutions: {
+            'json-stable-stringify': '1.0.2',
           },
         },
       },