-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems a very clear explanation to me. I'll ping someone with merge rights /cc @locks
We'd like the explanation to lean much more in the direction of |
cb0d74d
to
d2b6d8d
Compare
PR updated with added emphasis on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes added here look good (thank you!), but can you add a header above your changes for:
### Deprecations Added in 2.12
(since this deprecation will land in 2.12 which is the current emberjs/ember.js#master branch)
d2b6d8d
to
0053f6e
Compare
I don't know what to do about the failed deploy/netlify
|
@givanse it's not your fault, we're trying it out and all PRs are failing for some reason! |
0053f6e
to
7299e24
Compare
deprecate Ember.K according to emberjs/ember.js#14746
rendered view