Deprecate passing classBinding and classNameBindings as arguments
#691
Conversation
Co-authored-by: Jarek Radosz <[email protected]>
|
|
||
| ## How We Teach This | ||
|
|
||
| ### Deprecation Guide |
There was a problem hiding this comment.
Is there an until for this deprecation?
| Note that we are passing in the `@class` argument, not the `class` attribute. | ||
| This is to maintain the existing behavior exactly, but in most cases it will be | ||
| safe to convert to using the `class` attribute as well. It is only unsafe if you | ||
| were directly referencing the value of the `@class` argument anywhere in your | ||
| component. |
There was a problem hiding this comment.
I suggest to flip this around and use the class= syntax in the example (which is what most people are going to look at and copy) and only mention the caveat in text. I think it's extremely unlikely that this will matter to real apps – you would have to know that classBinding and classNameBindings transforms into the class argument, plus it doesn't give you access to other classes added by the JS code. You could argue this is not really supported even.
|
We discussed this on the framework core team meeting today and decided to move this into the final comment period (assuming @pzuraq is going to apply my suggestion above – but it's a small enough detail that doesn't materially changes much about the RFC). |
Rendered