Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC 566: rename @memo -> @cached #654

Merged
merged 1 commit into from
Aug 11, 2020
Merged

RFC 566: rename @memo -> @cached #654

merged 1 commit into from
Aug 11, 2020

Conversation

buschtoens
Copy link
Contributor

@buschtoens buschtoens commented Aug 11, 2020 •
edited
Loading

@buschtoens buschtoens mentioned this pull request Aug 11, 2020
Closed
4 tasks
rwjblue
rwjblue approved these changes Aug 11, 2020
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me, and reflects the discussions that we (core team) have had internally.

@rwjblue
Copy link
Member

rwjblue commented Aug 11, 2020

Thanks for sending the PR @buschtoens!

@rwjblue rwjblue merged commit 8900bb1 into emberjs:memo-decorator Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@buschtoens @rwjblue