Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DATA] RecordData Operations #458

Closed

Conversation

runspired
Copy link
Contributor

@runspired runspired added the T-ember-data RFCs that impact the ember-data library label Mar 6, 2019
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a number of things are still missing from this WIP:

  • explicit list of all operations
  • explicit list of all methods to be deprecated on record data
  • "how do we teach this" section / etc

text/0000-ember-data-record-data-operations.md Outdated Show resolved Hide resolved
text/0000-ember-data-record-data-operations.md Outdated Show resolved Hide resolved
text/0000-ember-data-record-data-operations.md Outdated Show resolved Hide resolved
text/0000-ember-data-record-data-operations.md Outdated Show resolved Hide resolved
@runspired runspired changed the title [WIP] Record Data Operations [WIP DATA] RecordData Operations Mar 7, 2019
@runspired runspired changed the title [WIP DATA] RecordData Operations [DATA] RecordData Operations Mar 12, 2019
@dgeb
Copy link
Member

dgeb commented Mar 13, 2019

Let's consider using Orbit's operations, which are very close in signature to the proposal here, in order to maximize compatibility: https://github.com/orbitjs/orbit/blob/master/packages/%40orbit/data/src/operation.ts#L4-L106

@dgeb
Copy link
Member

dgeb commented Mar 13, 2019

This proposal seems incomplete without operations that create, update, and remove records as a whole.

@runspired
Copy link
Contributor Author

Closing in favor of additional exploration internally in this space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-ember-data RFCs that impact the ember-data library
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants