Skip to content

Commit

Permalink
Updates
Browse files Browse the repository at this point in the history
  • Loading branch information
NullVoxPopuli committed Sep 20, 2024
1 parent 41e4eed commit 68f9b4d
Showing 1 changed file with 4 additions and 8 deletions.
12 changes: 4 additions & 8 deletions text/1009-move-deprecation-workflow-to-apps.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,19 +29,15 @@ project-link: Leave as is
suite: Leave as is
-->

# Move the deprecation workflow to apps by default
# Move the deprecation workflow library to be installed in apps by default

## Summary

Historically, folks have benefitted from [ember-cli-deprecation-workflow](https://github.com/mixonic/ember-cli-deprecation-workflow). This behavior is _so useful_, that it should be built in to folks applications by default.

tl;dr: move `setupDeprecationWorkflow` to `@ember/debug`

> One paragraph explanation of the feature.
## Motivation

Everyone needs a deprecation-workflow, and yet `ember-cli-deprecation-workflow` is not part of the default blueprint. It probably doesn't need to be as the code it provides (if implemented in an app) is ~ 20 lines (but is slightly more if we want all features).
Everyone needs a deprecation-workflow, and yet `ember-cli-deprecation-workflow` is not part of the default blueprint.

This RFC proposes how we can ship deprecation workflow handling behavior in apps by default, which may give us a blessed path for better integrating with build time deprecations as well (though that is not the focus of this RFC).

Expand Down Expand Up @@ -104,7 +100,7 @@ This README of [ember-cli-deprecation-workflow](https://github.com/ember-cli/emb

## Drawbacks

For older projects, this could be _a_ migration. But as it is additional blueprint boilerplate, it is optional, and `ember-cli-deprecation-workflow` would continue to be a viable option for those already using it.
For older projects, this could be _a_ migration. But as it is additional blueprint boilerplate, it is optional.

## Alternatives

Expand All @@ -130,7 +126,7 @@ However, folks can get a basic deprecation-handling workflow going in their apps
import config from 'test-app/config/environment';

+ if (macroCondition(isDevelopingApp())) {
+ importSync('<app-moduleName>/deprecation-workflow');
+ importSync('./deprecation-workflow');
+ }

export default class App extends Application {
Expand Down

0 comments on commit 68f9b4d

Please sign in to comment.